-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FeatureStore] Support SQL DBs as source and online target #2869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any change in requirments?
trying to run tests was getting error: ModuleNotFoundError: No module named 'MySQLdb'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase pr to latest development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- added some comments inline
- what about support for runtimes? seems MLRUN_SQL_DB_PATH_STRING is not propagated there, and no testing
- spark engine support?
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
8d9459d
to
0d5d086
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost done - few last comments.
This pr focus in implementation of source, target for SqlDB in mlrun.
SqlDB target can create or read from exists sql collection. The collection is fixed and can't change is schema in the flow.
not support spark
ML-2610